Swich statement in cfi_probe.c
David Woodhouse
dwmw2 at infradead.org
Mon Mar 12 12:27:10 EST 2001
rob at sysgo.de said:
> I noticed that in cfi_probe.c, routine cfi_probe_new_chip(), the
> cases following the switch(map->buswidth) are not terminated by a
> break. Thus if the probe fails for the given buswidth, the code will
> try all remaining buswidths too.
> Is that a bug or does it serve a purpose (if so, which ?)
Not sure. If it has a purpose, the only possibility I can think of off the
top of my head is to work around people giving the wrong buswidth. And I
think the code would probably break then anyway.
So it's probably a bug. If nobody shouts I'll add in the missing breaks.
--
dwmw2
To unsubscribe, send "unsubscribe mtd" to majordomo at infradead.org
More information about the linux-mtd
mailing list