MTD CVS update: 'mtd/kernel doc2001.c'

Udi Finkelstein udif at bigfoot.com
Thu Oct 26 02:46:28 EDT 2000


On Wed, 25 Oct 2000 18:01:13 +0800, Ollie Lho <ollie at sis.com.tw> wrote:

>David Woodhouse wrote:
>> 
>> ollie at infradead.org said:
>> > Log Message:
>> > use memcpy_(from|to)_io to increase perfromance a little bit
>> 
>> Here be dragons.
>> 
>> Beware that this doesn't start trying to do 32-bit accesses, where the top
>> three bytes are random, and that it doesn't break the ECC.
>> 
>> Probably worth setting USE_MEMCPY in include/linux/mtd/doc2000.h in with
>> all the other arch-dependent stuff to set up ReadDOC etc.
>> 
>
>Oops, sorry. I just copy it from the dis-asm of M-Systems' driver.
>USE_MEMCPY should be protected by #ifdef 386 stuff.

Do you put code disassembled from a proprietary M-systems' driver into a GPL
driver?
Do we really want that?

>Ollie

udi


To unsubscribe, send "unsubscribe mtd" to majordomo at infradead.org



More information about the linux-mtd mailing list