Three change suggestions to nand.c and friends.

[David Woodhouse]

mdeans at algonet.se said:
>  1) Right now the code needs the moddi3() helper to perform it's
> checks. I suggest adding the requirement that {.oobblock} must be a
> power of two. 

That's sensible, but best just to require it. Don't piss about with config
options.

>  2) I've also rewritten nand.c changing all 'NAND_CTRL |= this->CLE;'
> -> NAND_SET_CMD et.al. Different hardware different support code. 

Check with sjhill but that sounds reasonable.

>  3) I moved nand_flash_ids[] to a new file, nand_ids.h since nand.h is
> included in several different places and not all .c-files that
> #include it needs nand_flash_ids[] (thus creating dups). 

OK.



--
dwmw2




To unsubscribe, send "unsubscribe mtd" to majordomo at infradead.org