mtd: nand: denali: use int where no reason to use fixed width variable

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Wed May 10 19:59:10 PDT 2017


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=e30b46909bdf3ac8699a47cfd64b44fabc29f253
Commit:     e30b46909bdf3ac8699a47cfd64b44fabc29f253
Parent:     be72a4aa8ec1c13a55708bd0285106a5020ff72f
Author:     Masahiro Yamada <yamada.masahiro at socionext.com>
AuthorDate: Thu Mar 23 05:07:08 2017 +0900
Committer:  Boris Brezillon <boris.brezillon at free-electrons.com>
CommitDate: Fri Mar 24 09:51:41 2017 +0100

    mtd: nand: denali: use int where no reason to use fixed width variable
    
    The page number is generally stored in an integer type variable.
    The uint16_t does not have enough width.  I see no reason to use
    uint32_t for other members, either.  Just use int.
    
    Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
    Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
---
 drivers/mtd/nand/denali.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/nand/denali.h b/drivers/mtd/nand/denali.h
index eed001d..7b2d785 100644
--- a/drivers/mtd/nand/denali.h
+++ b/drivers/mtd/nand/denali.h
@@ -325,7 +325,7 @@ struct denali_nand_info {
 	struct nand_buf buf;
 	struct device *dev;
 	int total_used_banks;
-	uint16_t page;
+	int page;
 	void __iomem *flash_reg;	/* Register Interface */
 	void __iomem *flash_mem;	/* Host Data/Command Interface */
 
@@ -335,9 +335,9 @@ struct denali_nand_info {
 	uint32_t irq_status;
 	int irq;
 
-	uint32_t devnum;	/* represent how many nands connected */
-	uint32_t bbtskipbytes;
-	uint32_t max_banks;
+	int devnum;	/* represent how many nands connected */
+	int bbtskipbytes;
+	int max_banks;
 	unsigned int caps;
 };
 



More information about the linux-mtd-cvs mailing list