mtd: spi-nor: aspeed: remove dummies from keep mask

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Thu Jul 13 10:59:09 PDT 2017


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=a9f127bb5f92379ecb135a66bb89f8403e998d96
Commit:     a9f127bb5f92379ecb135a66bb89f8403e998d96
Parent:     d7c9ade2e31dbae4deaa8a5198107ecde4c56968
Author:     Cédric Le Goater <clg at kaod.org>
AuthorDate: Thu Apr 20 13:56:34 2017 +0200
Committer:  Cyrille Pitchen <cyrille.pitchen at wedev4u.fr>
CommitDate: Wed Jun 21 00:22:59 2017 +0200

    mtd: spi-nor: aspeed: remove dummies from keep mask
    
    There is no need to keep the dummy bytes in the control register if
    the command mode is not kept also. This could lead to an inconsistent
    setting : normal read mode (command 0x3) and dummy bytes. It is to be
    noted that the HW allows such a configuration.
    
    Signed-off-by: Cédric Le Goater <clg at kaod.org>
    Reviewed-by: Marek Vasut <marek.vasut at gmail.com>
    Signed-off-by: Cyrille Pitchen <cyrille.pitchen at wedev4u.fr>
---
 drivers/mtd/spi-nor/aspeed-smc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
index 3f875c8..d76663b 100644
--- a/drivers/mtd/spi-nor/aspeed-smc.c
+++ b/drivers/mtd/spi-nor/aspeed-smc.c
@@ -180,8 +180,7 @@ struct aspeed_smc_controller {
 
 #define CONTROL_KEEP_MASK						\
 	(CONTROL_AAF_MODE | CONTROL_CE_INACTIVE_MASK | CONTROL_CLK_DIV4 | \
-	 CONTROL_IO_DUMMY_MASK | CONTROL_CLOCK_FREQ_SEL_MASK |		\
-	 CONTROL_LSB_FIRST | CONTROL_CLOCK_MODE_3)
+	 CONTROL_CLOCK_FREQ_SEL_MASK | CONTROL_LSB_FIRST | CONTROL_CLOCK_MODE_3)
 
 /*
  * The Segment Register uses a 8MB unit to encode the start address



More information about the linux-mtd-cvs mailing list