mtd: nand: sunxi: Remove unneeded ->cmdfunc(NAND_CMD_READ0, 0, page)

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Thu Jul 13 10:59:15 PDT 2017


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=df5586d7bf6cce421ed48e9b2a88a8bdaa4fd9d0
Commit:     df5586d7bf6cce421ed48e9b2a88a8bdaa4fd9d0
Parent:     2de85e73360104d3582363dcebdcdd7dc20431be
Author:     Boris Brezillon <boris.brezillon at free-electrons.com>
AuthorDate: Tue May 16 00:23:46 2017 +0200
Committer:  Boris Brezillon <boris.brezillon at free-electrons.com>
CommitDate: Thu Jun 1 10:09:32 2017 +0200

    mtd: nand: sunxi: Remove unneeded ->cmdfunc(NAND_CMD_READ0, 0, page)
    
    The core already sends the NAND_CMD_READ0 for us. Duplicating this call
    in the driver is useless and introduces a perf penalty.
    
    Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
---
 drivers/mtd/nand/sunxi_nand.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/nand/sunxi_nand.c b/drivers/mtd/nand/sunxi_nand.c
index 9a46d1d..d0b6f8f 100644
--- a/drivers/mtd/nand/sunxi_nand.c
+++ b/drivers/mtd/nand/sunxi_nand.c
@@ -1301,7 +1301,6 @@ static int sunxi_nfc_hw_ecc_read_subpage(struct mtd_info *mtd,
 
 	sunxi_nfc_hw_ecc_enable(mtd);
 
-	chip->cmdfunc(mtd, NAND_CMD_READ0, 0, page);
 	for (i = data_offs / ecc->size;
 	     i < DIV_ROUND_UP(data_offs + readlen, ecc->size); i++) {
 		int data_off = i * ecc->size;



More information about the linux-mtd-cvs mailing list