mtd: nand: lpc32xx: fix invalid error handling of a requested irq

[Linux-MTD Mailing List]

Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=cf9e1672a66c49ed8903c01b4c380a2f2dc91b40
Commit:     cf9e1672a66c49ed8903c01b4c380a2f2dc91b40
Parent:     8043d25b3c0fa0a8f531333707f682f03b6febdb
Author:     Vladimir Zapolskiy <vz at mleia.com>
AuthorDate: Mon Dec 5 03:47:10 2016 +0200
Committer:  Boris Brezillon <boris.brezillon at free-electrons.com>
CommitDate: Wed Jan 4 20:50:18 2017 +0100

    mtd: nand: lpc32xx: fix invalid error handling of a requested irq
    
    Semantics of NR_IRQS is different on machines with SPARSE_IRQ option
    disabled or enabled, in the latter case IRQs are allocated starting
    at least from the value specified by NR_IRQS and going upwards, so
    the check of (irq >= NR_IRQ) to decide about an error code returned by
    platform_get_irq() is completely invalid, don't attempt to overrule
    irq subsystem in the driver.
    
    The change fixes LPC32xx NAND MLC driver initialization on boot.
    
    Fixes: 8cb17b5ed017 ("irqchip: Add LPC32xx interrupt controller driver")
    Cc: stable at kernel.org # v4.7+
    Signed-off-by: Vladimir Zapolskiy <vz at mleia.com>
    Acked-by: Sylvain Lemieux <slemieux.tyco at gmail.com>
    Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
---
 drivers/mtd/nand/lpc32xx_mlc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/lpc32xx_mlc.c b/drivers/mtd/nand/lpc32xx_mlc.c
index 5553a5d..846a66c 100644
--- a/drivers/mtd/nand/lpc32xx_mlc.c
+++ b/drivers/mtd/nand/lpc32xx_mlc.c
@@ -775,7 +775,7 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
 	init_completion(&host->comp_controller);
 
 	host->irq = platform_get_irq(pdev, 0);
-	if ((host->irq < 0) || (host->irq >= NR_IRQS)) {
+	if (host->irq < 0) {
 		dev_err(&pdev->dev, "failed to get platform irq\n");
 		res = -EINVAL;
 		goto err_exit3;