mtdpart: Propagate _get/put_device()

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Sat Oct 8 21:59:01 PDT 2016


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=5e149073ba427f99c5e751e558670d034a278f77
Commit:     5e149073ba427f99c5e751e558670d034a278f77
Parent:     f6d7c1b5598b6407c3f1da795dd54acf99c1990c
Author:     Richard Weinberger <richard at nod.at>
AuthorDate: Wed Sep 21 11:43:56 2016 +0200
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Wed Sep 28 13:00:45 2016 -0700

    mtdpart: Propagate _get/put_device()
    
    If the master device has callbacks for _get/put_device()
    and this MTD has slaves a get_mtd_device() call on paritions
    will never issue the registered callbacks.
    Fix this by propagating _get/put_device() down.
    
    Reviewed-by: Boris Brezillon <boris.brezillon at free-electrons.com>
    Signed-off-by: Richard Weinberger <richard at nod.at>
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 drivers/mtd/mtdpart.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index 1f13e32..ec852fa 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -317,6 +317,18 @@ static int part_block_markbad(struct mtd_info *mtd, loff_t ofs)
 	return res;
 }
 
+static int part_get_device(struct mtd_info *mtd)
+{
+	struct mtd_part *part = mtd_to_part(mtd);
+	return part->master->_get_device(part->master);
+}
+
+static void part_put_device(struct mtd_info *mtd)
+{
+	struct mtd_part *part = mtd_to_part(mtd);
+	part->master->_put_device(part->master);
+}
+
 static int part_ooblayout_ecc(struct mtd_info *mtd, int section,
 			      struct mtd_oob_region *oobregion)
 {
@@ -463,6 +475,12 @@ static struct mtd_part *allocate_partition(struct mtd_info *master,
 		slave->mtd._block_isbad = part_block_isbad;
 	if (master->_block_markbad)
 		slave->mtd._block_markbad = part_block_markbad;
+
+	if (master->_get_device)
+		slave->mtd._get_device = part_get_device;
+	if (master->_put_device)
+		slave->mtd._put_device = part_put_device;
+
 	slave->mtd._erase = part_erase;
 	slave->master = master;
 	slave->offset = part->offset;



More information about the linux-mtd-cvs mailing list