mtd: nand: sunxi: fix ->dev_ready() implementation

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Mon May 23 21:59:10 PDT 2016


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=a9a416f0c723e10ecccfe7ea30e93dfee0dbf10d
Commit:     a9a416f0c723e10ecccfe7ea30e93dfee0dbf10d
Parent:     336de7b1e07e6c666dbed522120547b852b3fba7
Author:     Boris Brezillon <boris.brezillon at free-electrons.com>
AuthorDate: Mon Mar 7 15:10:28 2016 +0100
Committer:  Boris Brezillon <boris.brezillon at free-electrons.com>
CommitDate: Tue Apr 19 22:05:44 2016 +0200

    mtd: nand: sunxi: fix ->dev_ready() implementation
    
    ->dev_ready() is not supposed to wait for busy to ready solution (this is
    the role of ->waitfunc()).
    
    Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
---
 drivers/mtd/nand/sunxi_nand.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/mtd/nand/sunxi_nand.c b/drivers/mtd/nand/sunxi_nand.c
index fe3730a..fff28512c 100644
--- a/drivers/mtd/nand/sunxi_nand.c
+++ b/drivers/mtd/nand/sunxi_nand.c
@@ -357,7 +357,6 @@ static int sunxi_nfc_dev_ready(struct mtd_info *mtd)
 	struct sunxi_nand_chip *sunxi_nand = to_sunxi_nand(nand);
 	struct sunxi_nfc *nfc = to_sunxi_nfc(sunxi_nand->nand.controller);
 	struct sunxi_nand_rb *rb;
-	unsigned long timeo = (sunxi_nand->nand.state == FL_ERASING ? 400 : 20);
 	int ret;
 
 	if (sunxi_nand->selected < 0)
@@ -369,12 +368,6 @@ static int sunxi_nfc_dev_ready(struct mtd_info *mtd)
 	case RB_NATIVE:
 		ret = !!(readl(nfc->regs + NFC_REG_ST) &
 			 NFC_RB_STATE(rb->info.nativeid));
-		if (ret)
-			break;
-
-		sunxi_nfc_wait_int(nfc, NFC_RB_B2R, timeo);
-		ret = !!(readl(nfc->regs + NFC_REG_ST) &
-			 NFC_RB_STATE(rb->info.nativeid));
 		break;
 	case RB_GPIO:
 		ret = gpio_get_value(rb->info.gpio);



More information about the linux-mtd-cvs mailing list