mtd: pmc551: add __init attribute

[Linux-MTD Mailing List]

Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=abbbc60a0c69e05c965ce51cb75c0bee56dc0025
Commit:     abbbc60a0c69e05c965ce51cb75c0bee56dc0025
Parent:     e4106a7c8236eb7b91686d36f3bf33ee43db94b4
Author:     Julia Lawall <julia.lawall at lip6.fr>
AuthorDate: Tue Apr 19 14:33:34 2016 +0200
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Tue Apr 26 00:18:29 2016 -0600

    mtd: pmc551: add __init attribute
    
    Add __init attribute on a function that is only called from other __init
    functions and that is not inlined, at least with gcc version 4.8.4 on an
    x86 machine with allyesconfig.  Currently, the function is put in the
    .text.unlikely segment.  Declaring it as __init will cause it to be put in
    the .init.text and to disappear after initialization.
    
    The result of objdump -x on the function before the change is as follows:
    
    00000000000000c6 l     F .text.unlikely 000000000000091c fixup_pmc551
    
    And after the change it is as follows:
    
    0000000000000000 l     F .init.text	0000000000000917 fixup_pmc551
    
    Done with the help of Coccinelle.  The semantic patch checks for local
    static non-init functions that are called from an __init function and are
    not called from any other function.
    
    Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 drivers/mtd/devices/pmc551.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/devices/pmc551.c b/drivers/mtd/devices/pmc551.c
index 708b7e8..220f920 100644
--- a/drivers/mtd/devices/pmc551.c
+++ b/drivers/mtd/devices/pmc551.c
@@ -353,7 +353,7 @@ static int pmc551_write(struct mtd_info *mtd, loff_t to, size_t len,
  * mechanism
  * returns the size of the memory region found.
  */
-static int fixup_pmc551(struct pci_dev *dev)
+static int __init fixup_pmc551(struct pci_dev *dev)
 {
 #ifdef CONFIG_MTD_PMC551_BUGFIX
 	u32 dram_data;