mtd: atmel_nand: Do not warn on bitflips

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Thu Mar 24 11:59:02 PDT 2016


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=12197bf21c26e23053fa6223f3a731a965542986
Commit:     12197bf21c26e23053fa6223f3a731a965542986
Parent:     4be4e03efc7f45ec002e8eddc83c22f80fed392c
Author:     Romain Izard <romain.izard.pro at gmail.com>
AuthorDate: Wed Jan 13 17:34:13 2016 +0100
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Sat Jan 23 12:43:33 2016 -0800

    mtd: atmel_nand: Do not warn on bitflips
    
    When using multi-bit ECC, it is normal for the NAND Flash driver to
    correct bit errors during the life of the product. Those errors will
    only be cleared once a threshold has been reached, and corrections can
    occur regularly before this.
    
    Use only dev_dbg and not dev_info to report the bitflips, to keep the
    system log clean when everything works correctly.
    
    Signed-off-by: Romain Izard <romain.izard.pro at gmail.com>
    Acked-by: Wenyou Yang <wenyou.yang at atmel.com>
    Reviewed-by: Boris Brezillon <boris.brezillon at free-electrons.com>
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 drivers/mtd/nand/atmel_nand.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index bddcf83..0ae6cba 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -825,7 +825,7 @@ static void pmecc_correct_data(struct mtd_info *mtd, uint8_t *buf, uint8_t *ecc,
 			*(buf + byte_pos) ^= (1 << bit_pos);
 
 			pos = sector_num * host->pmecc_sector_size + byte_pos;
-			dev_info(host->dev, "Bit flip in data area, byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n",
+			dev_dbg(host->dev, "Bit flip in data area, byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n",
 				pos, bit_pos, err_byte, *(buf + byte_pos));
 		} else {
 			/* Bit flip in OOB area */
@@ -835,7 +835,7 @@ static void pmecc_correct_data(struct mtd_info *mtd, uint8_t *buf, uint8_t *ecc,
 			ecc[tmp] ^= (1 << bit_pos);
 
 			pos = tmp + nand_chip->ecc.layout->eccpos[0];
-			dev_info(host->dev, "Bit flip in OOB, oob_byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n",
+			dev_dbg(host->dev, "Bit flip in OOB, oob_byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n",
 				pos, bit_pos, err_byte, ecc[tmp]);
 		}
 



More information about the linux-mtd-cvs mailing list