mtd: nand: denali: add missing nand_release() call in denali_remove()

[Linux-MTD Mailing List]

Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=320092a05dab2f44819c42f33d6b51efb6c474f2
Commit:     320092a05dab2f44819c42f33d6b51efb6c474f2
Parent:     207f6582dd9adb8e2ed64b4c64d6d5c009e5bbf9
Author:     Boris BREZILLON <boris.brezillon at free-electrons.com>
AuthorDate: Fri Dec 11 15:02:34 2015 +0100
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Fri Dec 11 12:42:46 2015 -0800

    mtd: nand: denali: add missing nand_release() call in denali_remove()
    
    Unregister the NAND device from the NAND subsystem when removing a denali
    NAND controller, otherwise the MTD attached to the NAND device is still
    exposed by the MTD layer, and accesses to this device will likely crash
    the system.
    
    Fixes: 2a0a288ec258 ("mtd: denali: split the generic driver and PCI layer")
    Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
    Acked-by: Dinh Nguyen <dinguyen at opensource.altera.com>
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 drivers/mtd/nand/denali.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
index 67eb2be..9a5035c 100644
--- a/drivers/mtd/nand/denali.c
+++ b/drivers/mtd/nand/denali.c
@@ -1622,9 +1622,16 @@ EXPORT_SYMBOL(denali_init);
 /* driver exit point */
 void denali_remove(struct denali_nand_info *denali)
 {
+	/*
+	 * Pre-compute DMA buffer size to avoid any problems in case
+	 * nand_release() ever changes in a way that mtd->writesize and
+	 * mtd->oobsize are not reliable after this call.
+	 */
+	int bufsize = denali->mtd.writesize + denali->mtd.oobsize;
+
+	nand_release(&denali->mtd);
 	denali_irq_cleanup(denali->irq, denali);
-	dma_unmap_single(denali->dev, denali->buf.dma_buf,
-			 denali->mtd.writesize + denali->mtd.oobsize,
+	dma_unmap_single(denali->dev, denali->buf.dma_buf, bufsize,
 			 DMA_BIDIRECTIONAL);
 }
 EXPORT_SYMBOL(denali_remove);