mtd: nand: pxa3xx: return error code of nand_scan_ident() on error

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Fri Dec 16 11:59:08 PST 2016


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=133fe8fa614175eb7e59599dbfe357c7bc7da851
Commit:     133fe8fa614175eb7e59599dbfe357c7bc7da851
Parent:     c8cae35572b6132e7c3fbb708ebee4b84e29bbed
Author:     Masahiro Yamada <yamada.masahiro at socionext.com>
AuthorDate: Fri Nov 4 19:43:08 2016 +0900
Committer:  Boris Brezillon <boris.brezillon at free-electrons.com>
CommitDate: Mon Nov 7 14:48:52 2016 +0100

    mtd: nand: pxa3xx: return error code of nand_scan_ident() on error
    
    The nand_scan_ident() returns an appropriate error value when it
    fails.  Use it instead of the fixed error code -ENODEV.
    (This driver is already doing so for nand_scan_tail().)
    
    Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
    Reviewed-by: Marek Vasut <marek.vasut at gmail.com>
    Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
---
 drivers/mtd/nand/pxa3xx_nand.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index 4c749b0..649ba82 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -1680,8 +1680,9 @@ static int pxa3xx_nand_scan(struct mtd_info *mtd)
 	chip->ecc.strength = pdata->ecc_strength;
 	chip->ecc.size = pdata->ecc_step_size;
 
-	if (nand_scan_ident(mtd, 1, NULL))
-		return -ENODEV;
+	ret = nand_scan_ident(mtd, 1, NULL);
+	if (ret)
+		return ret;
 
 	if (!pdata->keep_config) {
 		ret = pxa3xx_nand_init(host);



More information about the linux-mtd-cvs mailing list