mtd: core: tone down suggestion that dev.parent should be set

[Linux-MTD Mailing List]

Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=260e89a6e0d6dcaccd484cf13a69285c3d22268f
Commit:     260e89a6e0d6dcaccd484cf13a69285c3d22268f
Parent:     f9bcb6dc8013d4da6660556ddf2383e4fbcbe3d7
Author:     Frans Klaver <fransklaver at gmail.com>
AuthorDate: Wed Jun 10 22:38:15 2015 +0200
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Tue Oct 13 09:21:12 2015 -0700

    mtd: core: tone down suggestion that dev.parent should be set
    
    add_mtd_device() has a comment suggesting that the caller should have
    set dev.parent. This is required to have the parent device symlink show
    up in sysfs, but not for proper operation of the mtd device itself.
    Currently we have five drivers registering mtd devices during module
    initialization, so they don't actually provide a parent device to link
    to. That means we cannot WARN_ON() here, as it would trigger false
    positives.
    
    Make the comment a bit less firm in its assertion that dev.parent should
    be set.
    
    Signed-off-by: Frans Klaver <fransklaver at gmail.com>
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 drivers/mtd/mtdcore.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 8598e3b..ac280ee 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -430,7 +430,7 @@ int add_mtd_device(struct mtd_info *mtd)
 	}
 
 	/* Caller should have set dev.parent to match the
-	 * physical device.
+	 * physical device, if appropriate.
 	 */
 	mtd->dev.type = &mtd_devtype;
 	mtd->dev.class = &mtd_class;