mtd: chips: fixup dependencies, to prevent build error

[Linux-MTD Mailing List]

Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=bde90062a38160fdce0d51a4340bb93c1a8f1114
Commit:     bde90062a38160fdce0d51a4340bb93c1a8f1114
Parent:     636fdbf88efe069f9951d1b7df8d3fd82060dc60
Author:     Brian Norris <computersforpeace at gmail.com>
AuthorDate: Thu May 28 11:07:48 2015 -0700
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Thu May 28 11:07:48 2015 -0700

    mtd: chips: fixup dependencies, to prevent build error
    
    Commit 4612c715a6ea ("mtd: cfi: deinline large functions") moved some
    code into the cfi_util library without creating a new dependency. So we
    can get build failures like the following, when CONFIG_MTD_JEDECPROBE=y
    and CONFIG_MTD_CFI_UTIL=m.
    
       drivers/built-in.o: In function `jedec_read_id':
    >> jedec_probe.c:(.text+0x187ed8): undefined reference to `cfi_build_cmd_addr'
       drivers/built-in.o: In function `jedec_read_mfr':
    >> jedec_probe.c:(.text+0x187f4a): undefined reference to `cfi_build_cmd_addr'
       drivers/built-in.o: In function `jedec_reset':
    >> jedec_probe.c:(.text+0x187fe0): undefined reference to `cfi_send_gen_cmd'
    >> jedec_probe.c:(.text+0x188004): undefined reference to `cfi_send_gen_cmd'
    >> jedec_probe.c:(.text+0x18802b): undefined reference to `cfi_send_gen_cmd'
    >> jedec_probe.c:(.text+0x18804e): undefined reference to `cfi_send_gen_cmd'
       drivers/built-in.o: In function `jedec_probe_chip':
    >> jedec_probe.c:(.text+0x188130): undefined reference to `cfi_build_cmd_addr'
    >> jedec_probe.c:(.text+0x18814d): undefined reference to `cfi_build_cmd_addr'
    >> jedec_probe.c:(.text+0x1881dc): undefined reference to `cfi_send_gen_cmd'
    >> jedec_probe.c:(.text+0x188203): undefined reference to `cfi_send_gen_cmd'
    >> jedec_probe.c:(.text+0x18822d): undefined reference to `cfi_send_gen_cmd'
    >> jedec_probe.c:(.text+0x1884c0): undefined reference to `cfi_send_gen_cmd'
    >> jedec_probe.c:(.text+0x1884e7): undefined reference to `cfi_send_gen_cmd'
       drivers/built-in.o:jedec_probe.c:(.text+0x188511): more undefined references to `cfi_send_gen_cmd' follow
       drivers/built-in.o: In function `jedec_probe_chip':
    >> jedec_probe.c:(.text+0x188618): undefined reference to `cfi_build_cmd'
    
    So let's express the dependency properly.
    
    Reported-by: kbuild test robot <fengguang.wu at intel.com>
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 drivers/mtd/chips/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/chips/Kconfig b/drivers/mtd/chips/Kconfig
index 9f02c28..54479c4 100644
--- a/drivers/mtd/chips/Kconfig
+++ b/drivers/mtd/chips/Kconfig
@@ -16,6 +16,7 @@ config MTD_CFI
 config MTD_JEDECPROBE
 	tristate "Detect non-CFI AMD/JEDEC-compatible flash chips"
 	select MTD_GEN_PROBE
+	select MTD_CFI_UTIL
 	help
 	  This option enables JEDEC-style probing of flash chips which are not
 	  compatible with the Common Flash Interface, but will use the common