mtd: brcmnand: do not make local variable static

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Tue Jun 23 10:59:04 PDT 2015


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=bcb83a19d3ac95fe3c0e79e942fb628120738853
Commit:     bcb83a19d3ac95fe3c0e79e942fb628120738853
Parent:     802041247a0abbeaf1dddb8a8d56f491762ae357
Author:     Hauke Mehrtens <hauke at hauke-m.de>
AuthorDate: Sun May 17 17:41:01 2015 +0200
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Mon May 18 11:02:49 2015 -0700

    mtd: brcmnand: do not make local variable static
    
    Remove static in front of ctrl. This variable should not be shared
    between different instances of brcmnand_probe(), it should be local to
    this function and stored on the stack.
    
    Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 drivers/mtd/nand/brcmnand/brcmnand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
index bae30ab..a48ad49 100644
--- a/drivers/mtd/nand/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/brcmnand/brcmnand.c
@@ -2069,7 +2069,7 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
 {
 	struct device *dev = &pdev->dev;
 	struct device_node *dn = dev->of_node, *child;
-	static struct brcmnand_controller *ctrl;
+	struct brcmnand_controller *ctrl;
 	struct resource *res;
 	int ret;
 



More information about the linux-mtd-cvs mailing list