mtd: mxc-nand: Warn on unimplemented commands

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Wed Apr 22 10:59:03 PDT 2015


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=98ebb521096f2d90c3e903ba79412cd92064795b
Commit:     98ebb521096f2d90c3e903ba79412cd92064795b
Parent:     3d6e81c0c9827c86fd3fe4bcbc44155b1401f80e
Author:     Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
AuthorDate: Tue Feb 10 20:00:00 2015 +0100
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Wed Mar 11 15:20:42 2015 -0700

    mtd: mxc-nand: Warn on unimplemented commands
    
    The PARAM command was long unimplemented and it probably wasn't
    noticed because chip probing using only the few bytes returned by the
    READID command are good enough in most cases to determine the chip in
    use.
    
    Still to notice such a shortcoming earlier in the future would be nice
    in case it's something more vital.
    
    Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 drivers/mtd/nand/mxc_nand.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index 0083b4e..372e0e3 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -1160,6 +1160,10 @@ static void mxc_nand_command(struct mtd_info *mtd, unsigned command,
 		memcpy32_fromio(host->data_buf, host->main_area0, 512);
 		host->buf_start = 0;
 		break;
+	default:
+		WARN_ONCE(1, "Unimplemented command (cmd=%u)\n",
+			  command);
+		break;
 	}
 }
 



More information about the linux-mtd-cvs mailing list