mtd: m25p80: get rid of spi_get_device_id

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Sun Nov 2 13:59:02 PST 2014


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=90e55b3812a1245bb674afcc4410ddba7db402f6
Commit:     90e55b3812a1245bb674afcc4410ddba7db402f6
Parent:     8b3d58e554453ab858bbb169d93b7321bdc628d4
Author:     Rafał Miłecki <zajec5 at gmail.com>
AuthorDate: Mon Sep 29 11:47:53 2014 +0200
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Fri Oct 17 09:29:21 2014 -0700

    mtd: m25p80: get rid of spi_get_device_id
    
    This simplifies the way we use spi_nor framework and will allow us to
    drop spi_nor_match_id.
    
    Signed-off-by: Rafał Miłecki <zajec5 at gmail.com>
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 drivers/mtd/devices/m25p80.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index dcda628..822209d 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -197,6 +197,7 @@ static int m25p_probe(struct spi_device *spi)
 	struct m25p *flash;
 	struct spi_nor *nor;
 	enum read_mode mode = SPI_NOR_NORMAL;
+	char *flash_name = NULL;
 	int ret;
 
 	data = dev_get_platdata(&spi->dev);
@@ -236,12 +237,11 @@ static int m25p_probe(struct spi_device *spi)
 	 * If that's the case, respect "type" and ignore a "name".
 	 */
 	if (data && data->type)
-		id = spi_nor_match_id(data->type);
-
-	/* If we didn't get name from platform, simply use "modalias". */
-	if (!id)
-		id = spi_get_device_id(spi);
+		flash_name = data->type;
+	else
+		flash_name = spi->modalias;
 
+	id = spi_nor_match_id(flash_name);
 	ret = spi_nor_scan(nor, id, mode);
 	if (ret)
 		return ret;



More information about the linux-mtd-cvs mailing list