jffs2: fix sparse warning: unexpected unlock

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Mon Dec 15 19:59:02 PST 2014


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=7f4028b29658a3ad63e83352af6ce2dae4fe7cdf
Commit:     7f4028b29658a3ad63e83352af6ce2dae4fe7cdf
Parent:     a72fe6b2ce7fd39d1df4cb4bb0330348824c6025
Author:     Fabian Frederick <fabf at skynet.be>
AuthorDate: Sun Sep 28 21:26:32 2014 +0200
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Wed Oct 22 01:35:41 2014 -0700

    jffs2: fix sparse warning: unexpected unlock
    
    fs/jffs2/summary.c:846:5: warning: context imbalance in 'jffs2_sum_write_sumnode' - unexpected unlock
    
    Suggested-by: Brian Norris <computersforpeace at gmail.com>
    Suggested-by: Josh Triplett <josh at joshtriplett.org>
    Signed-off-by: Fabian Frederick <fabf at skynet.be>
    Reviewed-by: Josh Triplett <josh at joshtriplett.org>
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 fs/jffs2/summary.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/jffs2/summary.c b/fs/jffs2/summary.c
index c522d09..bc53854 100644
--- a/fs/jffs2/summary.c
+++ b/fs/jffs2/summary.c
@@ -844,6 +844,7 @@ static int jffs2_sum_write_data(struct jffs2_sb_info *c, struct jffs2_eraseblock
 /* Write out summary information - called from jffs2_do_reserve_space */
 
 int jffs2_sum_write_sumnode(struct jffs2_sb_info *c)
+	__must_hold(&c->erase_completion_block)
 {
 	int datasize, infosize, padsize;
 	struct jffs2_eraseblock *jeb;



More information about the linux-mtd-cvs mailing list