mtd: lpc32xx: drop bitflip_threshold initialization

[Linux-MTD Mailing List]

Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=adddcac0a2683b93c106c6297c7c7e66498bcdde
Commit:     adddcac0a2683b93c106c6297c7c7e66498bcdde
Parent:     7171511eaec5bf23fb06078f59784a3a0626b38f
Author:     Brian Norris <computersforpeace at gmail.com>
AuthorDate: Wed May 28 01:45:56 2014 -0700
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Tue Jul 1 18:55:02 2014 -0700

    mtd: lpc32xx: drop bitflip_threshold initialization
    
    These drivers don't need to explicitly initialize their bitflip
    thresholds. The comment is no longer correct, since nand_scan_tail()
    performs this initialization as of the following commit:
    
        commit ea3b2ea24ef0f2ef9c6795b19cff456195b6728a
        Author: Shmulik Ladkani <shmulik at jungo.com>
        Date:   Fri Jun 8 18:29:06 2012 +0300
    
            mtd: nand: initialize bitflip_threshold prior to BBT scanning
    
    (It seems there were some parallel efforts on writing/submitting these
    drivers, and Shmulik's bug fix.)
    
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
    Cc: Roland Stigge <stigge at antcom.de>
---
 drivers/mtd/nand/lpc32xx_mlc.c | 6 ------
 drivers/mtd/nand/lpc32xx_slc.c | 6 ------
 2 files changed, 12 deletions(-)

diff --git a/drivers/mtd/nand/lpc32xx_mlc.c b/drivers/mtd/nand/lpc32xx_mlc.c
index 687478c..7335346 100644
--- a/drivers/mtd/nand/lpc32xx_mlc.c
+++ b/drivers/mtd/nand/lpc32xx_mlc.c
@@ -721,12 +721,6 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
 	nand_chip->bbt_td = &lpc32xx_nand_bbt;
 	nand_chip->bbt_md = &lpc32xx_nand_bbt_mirror;
 
-	/* bitflip_threshold's default is defined as ecc_strength anyway.
-	 * Unfortunately, it is set only later at add_mtd_device(). Meanwhile
-	 * being 0, it causes bad block table scanning errors in
-	 * nand_scan_tail(), so preparing it here. */
-	mtd->bitflip_threshold = nand_chip->ecc.strength;
-
 	if (use_dma) {
 		res = lpc32xx_dma_setup(host);
 		if (res) {
diff --git a/drivers/mtd/nand/lpc32xx_slc.c b/drivers/mtd/nand/lpc32xx_slc.c
index 53a6742..8caef28 100644
--- a/drivers/mtd/nand/lpc32xx_slc.c
+++ b/drivers/mtd/nand/lpc32xx_slc.c
@@ -840,12 +840,6 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
 	chip->ecc.strength = 1;
 	chip->ecc.hwctl = lpc32xx_nand_ecc_enable;
 
-	/* bitflip_threshold's default is defined as ecc_strength anyway.
-	 * Unfortunately, it is set only later at add_mtd_device(). Meanwhile
-	 * being 0, it causes bad block table scanning errors in
-	 * nand_scan_tail(), so preparing it here already. */
-	mtd->bitflip_threshold = chip->ecc.strength;
-
 	/*
 	 * Allocate a large enough buffer for a single huge page plus
 	 * extra space for the spare area and ECC storage area