mtd: remove some duplicative checks
Linux-MTD Mailing List
linux-mtd at lists.infradead.org
Sat Apr 5 02:59:02 EDT 2014
Gitweb: http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=da22b89386e8d4dc89525801dfe60f5f8c29668d
Commit: da22b89386e8d4dc89525801dfe60f5f8c29668d
Parent: 74414a945ac992c71766bbf76718c7fddbcbd016
Author: Dan Carpenter <dan.carpenter at oracle.com>
AuthorDate: Thu Feb 13 14:21:44 2014 +0300
Committer: Brian Norris <computersforpeace at gmail.com>
CommitDate: Mon Mar 10 22:42:25 2014 -0700
mtd: remove some duplicative checks
"rc" is an error code here, no need to check it a second time.
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
drivers/mtd/rfd_ftl.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/rfd_ftl.c b/drivers/mtd/rfd_ftl.c
index 233b946..d1cbf26 100644
--- a/drivers/mtd/rfd_ftl.c
+++ b/drivers/mtd/rfd_ftl.c
@@ -602,8 +602,7 @@ static int mark_sector_deleted(struct partition *part, u_long old_addr)
if (rc) {
printk(KERN_ERR PREFIX "error writing '%s' at "
"0x%lx\n", part->mbd.mtd->name, addr);
- if (rc)
- goto err;
+ goto err;
}
if (block == part->current_block)
part->header_cache[offset + HEADER_MAP_OFFSET] = del;
@@ -675,8 +674,7 @@ static int do_writesect(struct mtd_blktrans_dev *dev, u_long sector, char *buf,
if (rc) {
printk(KERN_ERR PREFIX "error writing '%s' at 0x%lx\n",
part->mbd.mtd->name, addr);
- if (rc)
- goto err;
+ goto err;
}
part->sector_map[sector] = addr;
@@ -695,8 +693,7 @@ static int do_writesect(struct mtd_blktrans_dev *dev, u_long sector, char *buf,
if (rc) {
printk(KERN_ERR PREFIX "error writing '%s' at 0x%lx\n",
part->mbd.mtd->name, addr);
- if (rc)
- goto err;
+ goto err;
}
block->used_sectors++;
block->free_sectors--;
More information about the linux-mtd-cvs
mailing list