GFS2: Fix ref count bug relating to atomic_open

[Linux-MTD Mailing List]

Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=ea0341e071527d5cec350917b01ab901af09d758
Commit:     ea0341e071527d5cec350917b01ab901af09d758
Parent:     e3c4269d139db7471ee560fb30948179e180b3d4
Author:     Steven Whitehouse <swhiteho at redhat.com>
AuthorDate: Thu Nov 21 18:47:57 2013 +0000
Committer:  Steven Whitehouse <swhiteho at redhat.com>
CommitDate: Thu Nov 21 18:47:57 2013 +0000

    GFS2: Fix ref count bug relating to atomic_open
    
    In the case that atomic_open calls finish_no_open() with
    the dentry that was supplied to gfs2_atomic_open() an
    extra reference count is required. This patch fixes that
    issue preventing a bug trap triggering at umount time.
    
    Signed-off-by: Steven Whitehouse <swhiteho at redhat.com>
---
 fs/gfs2/inode.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 1615df1..7119504 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -1171,8 +1171,11 @@ static int gfs2_atomic_open(struct inode *dir, struct dentry *dentry,
 	if (d != NULL)
 		dentry = d;
 	if (dentry->d_inode) {
-		if (!(*opened & FILE_OPENED))
+		if (!(*opened & FILE_OPENED)) {
+			if (d == NULL)
+				dget(dentry);
 			return finish_no_open(file, dentry);
+		}
 		dput(d);
 		return 0;
 	}