mtd: pci: remove unnecessary pci_set_drvdata()

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Wed Nov 13 13:59:03 EST 2013


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=cd688920c549da7dbe303dfe21575d4a88adde38
Commit:     cd688920c549da7dbe303dfe21575d4a88adde38
Parent:     fe7feb9983dc4f5caadc72c11cee1f1162930533
Author:     Jingoo Han <jg1.han at samsung.com>
AuthorDate: Mon Sep 23 10:30:52 2013 +0900
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Wed Nov 6 23:32:43 2013 -0800

    mtd: pci: remove unnecessary pci_set_drvdata()
    
    The driver core clears the driver data to NULL after device_release
    or on probe failure. Thus, it is not needed to manually clear the
    device driver data to NULL.
    
    Signed-off-by: Jingoo Han <jg1.han at samsung.com>
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 drivers/mtd/maps/pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/maps/pci.c b/drivers/mtd/maps/pci.c
index c2604f8..36da518 100644
--- a/drivers/mtd/maps/pci.c
+++ b/drivers/mtd/maps/pci.c
@@ -316,7 +316,6 @@ static void mtd_pci_remove(struct pci_dev *dev)
 	map->exit(dev, map);
 	kfree(map);
 
-	pci_set_drvdata(dev, NULL);
 	pci_release_regions(dev);
 }
 



More information about the linux-mtd-cvs mailing list