mtd: scb2_flash: remove unnecessary pci_set_drvdata()

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Wed Nov 13 13:59:03 EST 2013


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=4d47011b39a8a2cd29560fee708681b20a5e9a8b
Commit:     4d47011b39a8a2cd29560fee708681b20a5e9a8b
Parent:     cd688920c549da7dbe303dfe21575d4a88adde38
Author:     Jingoo Han <jg1.han at samsung.com>
AuthorDate: Mon Sep 23 10:31:30 2013 +0900
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Wed Nov 6 23:32:44 2013 -0800

    mtd: scb2_flash: remove unnecessary pci_set_drvdata()
    
    The driver core clears the driver data to NULL after device_release
    or on probe failure. Thus, it is not needed to manually clear the
    device driver data to NULL.
    
    Signed-off-by: Jingoo Han <jg1.han at samsung.com>
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 drivers/mtd/maps/scb2_flash.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/maps/scb2_flash.c b/drivers/mtd/maps/scb2_flash.c
index c77b68c..3051c4c 100644
--- a/drivers/mtd/maps/scb2_flash.c
+++ b/drivers/mtd/maps/scb2_flash.c
@@ -212,7 +212,6 @@ static void scb2_flash_remove(struct pci_dev *dev)
 
 	if (!region_fail)
 		release_mem_region(SCB2_ADDR, SCB2_WINDOW);
-	pci_set_drvdata(dev, NULL);
 }
 
 static struct pci_device_id scb2_flash_pci_ids[] = {



More information about the linux-mtd-cvs mailing list