mtd: maps: plat-ram: remove unnecessary platform_set_drvdata()

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Mon Aug 5 16:59:05 EDT 2013


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=b36b5e9d128b7795794ce84a4ce308ea5c1a3c38
Commit:     b36b5e9d128b7795794ce84a4ce308ea5c1a3c38
Parent:     d5d093121e305e7df630a80bd656b357ba6674c1
Author:     Jingoo Han <jg1.han at samsung.com>
AuthorDate: Tue May 7 15:19:51 2013 +0900
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Mon Aug 5 20:59:29 2013 +0100

    mtd: maps: plat-ram: remove unnecessary platform_set_drvdata()
    
    The driver core clears the driver data to NULL after device_release
    or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
    (device-core: Ensure drvdata = NULL when no driver is bound).
    Thus, it is not needed to manually clear the device driver data to NULL.
    
    Signed-off-by: Jingoo Han <jg1.han at samsung.com>
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
    Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
 drivers/mtd/maps/plat-ram.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mtd/maps/plat-ram.c b/drivers/mtd/maps/plat-ram.c
index 71fdda2..b0b85eb 100644
--- a/drivers/mtd/maps/plat-ram.c
+++ b/drivers/mtd/maps/plat-ram.c
@@ -84,8 +84,6 @@ static int platram_remove(struct platform_device *pdev)
 {
 	struct platram_info *info = to_platram_info(pdev);
 
-	platform_set_drvdata(pdev, NULL);
-
 	dev_dbg(&pdev->dev, "removing device\n");
 
 	if (info == NULL)



More information about the linux-mtd-cvs mailing list