mtd: maps: sa1100-flash: remove unnecessary platform_set_drvdata()

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Mon Aug 5 16:59:05 EDT 2013


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=8e041c8abd51371b0f588e0f91b9876fa01a6b98
Commit:     8e041c8abd51371b0f588e0f91b9876fa01a6b98
Parent:     b36b5e9d128b7795794ce84a4ce308ea5c1a3c38
Author:     Jingoo Han <jg1.han at samsung.com>
AuthorDate: Tue May 7 15:20:58 2013 +0900
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Mon Aug 5 20:59:31 2013 +0100

    mtd: maps: sa1100-flash: remove unnecessary platform_set_drvdata()
    
    The driver core clears the driver data to NULL after device_release
    or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
    (device-core: Ensure drvdata = NULL when no driver is bound).
    Thus, it is not needed to manually clear the device driver data to NULL.
    
    Signed-off-by: Jingoo Han <jg1.han at samsung.com>
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
    Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
 drivers/mtd/maps/sa1100-flash.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/maps/sa1100-flash.c b/drivers/mtd/maps/sa1100-flash.c
index 29e3dca..9e70f8e 100644
--- a/drivers/mtd/maps/sa1100-flash.c
+++ b/drivers/mtd/maps/sa1100-flash.c
@@ -279,7 +279,6 @@ static int __exit sa1100_mtd_remove(struct platform_device *pdev)
 	struct sa_info *info = platform_get_drvdata(pdev);
 	struct flash_platform_data *plat = pdev->dev.platform_data;
 
-	platform_set_drvdata(pdev, NULL);
 	sa1100_destroy(info, plat);
 
 	return 0;



More information about the linux-mtd-cvs mailing list