mtd: nand: atmel_nand: remove unnecessary platform_set_drvdata()

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Mon Aug 5 16:59:04 EDT 2013


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=91e859211af012555672e090106183a691ed71e2
Commit:     91e859211af012555672e090106183a691ed71e2
Parent:     8f1f06272000fe970d211060bd7a73956eadd0c4
Author:     Jingoo Han <jg1.han at samsung.com>
AuthorDate: Tue May 7 15:33:27 2013 +0900
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Mon Aug 5 20:58:33 2013 +0100

    mtd: nand: atmel_nand: remove unnecessary platform_set_drvdata()
    
    The driver core clears the driver data to NULL after device_release
    or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
    (device-core: Ensure drvdata = NULL when no driver is bound).
    Thus, it is not needed to manually clear the device driver data to NULL.
    
    Signed-off-by: Jingoo Han <jg1.han at samsung.com>
    Acked-by: Josh Wu <josh.wu at atmel.com>
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
    Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
 drivers/mtd/nand/atmel_nand.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 61d3869..7e50ed8 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -1659,7 +1659,6 @@ err_hw_ecc:
 err_scan_ident:
 err_no_card:
 	atmel_nand_disable(host);
-	platform_set_drvdata(pdev, NULL);
 	if (host->dma_chan)
 		dma_release_channel(host->dma_chan);
 err_ecc_ioremap:



More information about the linux-mtd-cvs mailing list