mtd: mtdcore: cleanup mtdcore.h a little

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Fri Apr 5 08:59:11 EDT 2013


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=cb70783c65c2eb1b4593fc0b285ddd6d38499185
Commit:     cb70783c65c2eb1b4593fc0b285ddd6d38499185
Parent:     57ae2b609f9338875daf269146f89c176831232c
Author:     Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
AuthorDate: Fri Mar 15 13:02:19 2013 +0200
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Fri Apr 5 13:15:53 2013 +0100

    mtd: mtdcore: cleanup mtdcore.h a little
    
    Remove useless extern qualifiers. Not that this is a problem, but we more often
    declare function prototypes without 'extern', so this is just about being more
    consistent. And I am going to add a couple more prototypes here.
    
    Additionally, remove a useless comment.
    
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
    Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
 drivers/mtd/mtdcore.h | 46 ++++++++++++++++++++--------------------------
 1 file changed, 20 insertions(+), 26 deletions(-)

diff --git a/drivers/mtd/mtdcore.h b/drivers/mtd/mtdcore.h
dissimilarity index 76%
index 62bf5ac..9b10fed 100644
--- a/drivers/mtd/mtdcore.h
+++ b/drivers/mtd/mtdcore.h
@@ -1,26 +1,20 @@
-/* linux/drivers/mtd/mtdcore.h
- *
- * Header file for driver private mtdcore exports
- *
- */
-
-/* These are exported solely for the purpose of mtd_blkdevs.c. You
-   should not use them for _anything_ else */
-
-extern struct mutex mtd_table_mutex;
-extern struct mtd_info *__mtd_next_device(int i);
-
-extern int add_mtd_device(struct mtd_info *mtd);
-extern int del_mtd_device(struct mtd_info *mtd);
-extern int add_mtd_partitions(struct mtd_info *, const struct mtd_partition *,
-			      int);
-extern int del_mtd_partitions(struct mtd_info *);
-extern int parse_mtd_partitions(struct mtd_info *master,
-				const char * const *types,
-				struct mtd_partition **pparts,
-				struct mtd_part_parser_data *data);
-
-#define mtd_for_each_device(mtd)			\
-	for ((mtd) = __mtd_next_device(0);		\
-	     (mtd) != NULL;				\
-	     (mtd) = __mtd_next_device(mtd->index + 1))
+/*
+ * These are exported solely for the purpose of mtd_blkdevs.c. You
+ * should not use them for _anything_ else.
+ */
+
+extern struct mutex mtd_table_mutex;
+
+struct mtd_info *__mtd_next_device(int i);
+int add_mtd_device(struct mtd_info *mtd);
+int del_mtd_device(struct mtd_info *mtd);
+int add_mtd_partitions(struct mtd_info *, const struct mtd_partition *, int);
+int del_mtd_partitions(struct mtd_info *);
+int parse_mtd_partitions(struct mtd_info *master, const char * const *types,
+			 struct mtd_partition **pparts,
+			 struct mtd_part_parser_data *data);
+
+#define mtd_for_each_device(mtd)			\
+	for ((mtd) = __mtd_next_device(0);		\
+	     (mtd) != NULL;				\
+	     (mtd) = __mtd_next_device(mtd->index + 1))



More information about the linux-mtd-cvs mailing list