mtd: nand: use more reasonable integer types

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Fri Apr 5 08:59:09 EDT 2013


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=ecb42fea59cf2d1e7160c5c7e707120e0e6714db
Commit:     ecb42fea59cf2d1e7160c5c7e707120e0e6714db
Parent:     97135118bd6a5fb86a7e3a28a50de10b97192ced
Author:     Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
AuthorDate: Wed Mar 13 13:45:00 2013 +0200
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Fri Apr 5 13:15:00 2013 +0100

    mtd: nand: use more reasonable integer types
    
    Use 'unsigned int' instead of 'unsigned long' in the NAND chip description data
    structure, because 32-bits is more than enough for our purposes. We do not need
    64-bits, which is what we end up on 64-bit architectures. We declare many
    instances of this data structure, so this should help saving some amount of
    memory.
    
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
    Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
 include/linux/mtd/nand.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index 9a1b74c..d5903c0 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -582,8 +582,8 @@ struct nand_chip {
  * @pagesize: size of the NAND page in bytes; if 0, then the real page size (as
  *            well as the eraseblock size) is determined from the extended NAND
  *            chip ID array)
- * @erasesize: eraseblock size in bytes (determined from the extended ID if 0)
  * @chipsize: total chip size in MiB
+ * @erasesize: eraseblock size in bytes (determined from the extended ID if 0)
  * @options: stores various chip bit options
  */
 struct nand_flash_dev {
@@ -595,10 +595,10 @@ struct nand_flash_dev {
 		};
 		uint8_t id[8];
 	};
-	unsigned long pagesize;
-	unsigned long chipsize;
-	unsigned long erasesize;
-	unsigned long options;
+	unsigned int pagesize;
+	unsigned int chipsize;
+	unsigned int erasesize;
+	unsigned int options;
 };
 
 /**



More information about the linux-mtd-cvs mailing list