mtd: gpmi: do not set the default values for the extra clocks

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Sat Sep 29 10:59:53 EDT 2012


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=e1ca95e3a93c9a0392163a7a6791deda48b5eeca
Commit:     e1ca95e3a93c9a0392163a7a6791deda48b5eeca
Parent:     c50d35a9fdb628c5fcce5c2d4ab5ad9bedb2edb9
Author:     Huang Shijie <b32955 at freescale.com>
AuthorDate: Thu Sep 13 14:57:58 2012 +0800
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Sat Sep 29 15:56:07 2012 +0100

    mtd: gpmi: do not set the default values for the extra clocks
    
    The default frequencies of the extra clocks are 200MHz.
    The current code sets the extra clocks to 44.5MHz.
    
    When i add the EDO feature to gpmi, i have to revert the extra clocks
    to 200MHz.
    
    So it is better that we do not set the default values for the extra
    clocks. The driver runs well even when we do not set the default values for
    extra clocks.
    
    Signed-off-by: Huang Shijie <b32955 at freescale.com>
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
    Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
 drivers/mtd/nand/gpmi-nand/gpmi-nand.c |   15 +++++----------
 1 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 5999b15..2bfd448 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -516,20 +516,15 @@ static int __devinit gpmi_get_clks(struct gpmi_nand_data *this)
 		r->clock[i] = clk;
 	}
 
-	if (GPMI_IS_MX6Q(this)) {
+	if (GPMI_IS_MX6Q(this))
 		/*
-		 * Set the default values for the clocks in mx6q:
-		 *    The main clock(enfc) : 22MHz
-		 *    The others           : 44.5MHz
+		 * Set the default value for the gpmi clock in mx6q:
 		 *
-		 * These are just the default values. If you want to use
-		 * the ONFI nand which is in the Synchronous Mode, you should
-		 * change the clocks's frequencies as you need.
+		 * If you want to use the ONFI nand which is in the
+		 * Synchronous Mode, you should change the clock as you need.
 		 */
 		clk_set_rate(r->clock[0], 22000000);
-		for (i = 1; i < GPMI_CLK_MAX && r->clock[i]; i++)
-			clk_set_rate(r->clock[i], 44500000);
-	}
+
 	return 0;
 
 err_clock:



More information about the linux-mtd-cvs mailing list