jffs2: remove unnecessary GC pass on umount

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Mon May 28 07:59:11 EDT 2012


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=c3c4a36979c8b68cc35643497e83c7383cd07955
Commit:     c3c4a36979c8b68cc35643497e83c7383cd07955
Parent:     f4d0b3557582808d5ce9f868e9dfd98f0e769e82
Author:     Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
AuthorDate: Mon May 7 18:45:39 2012 +0300
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Sun May 13 23:23:01 2012 -0500

    jffs2: remove unnecessary GC pass on umount
    
    We do not need to call 'jffs2_write_super()' on unmount. This function
    causes a GC pass to make sure the current contents is pushed out with
    the data which we already have on the media.
    
    But this is not needed on unmount and only slows unmount down unnecessarily.
    It is enough to just sync the write-buffer.
    
    This call was added by one of the generic VFS rework patch-sets,
    see 8c85e125124a473d6f3e9bb187b0b84207f81d91.
    
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
    Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
 fs/jffs2/super.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
index 3f1c90c..1613cd2 100644
--- a/fs/jffs2/super.c
+++ b/fs/jffs2/super.c
@@ -333,9 +333,6 @@ static void jffs2_put_super (struct super_block *sb)
 
 	jffs2_dbg(2, "%s()\n", __func__);
 
-	if (sb->s_dirt)
-		jffs2_write_super(sb);
-
 	mutex_lock(&c->alloc_sem);
 	jffs2_flush_wbuf_pad(c);
 	mutex_unlock(&c->alloc_sem);



More information about the linux-mtd-cvs mailing list