jffs2: remove unnecessary GC pass on sync

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Mon May 28 07:59:11 EDT 2012


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=e832579fd100eb4f9658bdfefd61caf86a6cbff1
Commit:     e832579fd100eb4f9658bdfefd61caf86a6cbff1
Parent:     c3c4a36979c8b68cc35643497e83c7383cd07955
Author:     Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
AuthorDate: Mon May 7 18:51:54 2012 +0300
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Sun May 13 23:23:12 2012 -0500

    jffs2: remove unnecessary GC pass on sync
    
    We do not need to call 'jffs2_write_super()' on sync. This function
    causes a GC pass to make sure the current contents is pushed out with
    the data which we already have on the media.
    
    But this is not needed on unmount and only slows sync down unnecessarily.
    It is enough to just sync the write-buffer.
    
    This call was added by one of the generic VFS rework patch-sets,
    see d579ed00aa96a7f7486978540a0d7cecaff742ae.
    
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
    Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
 fs/jffs2/super.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
index 1613cd2..b36aa95 100644
--- a/fs/jffs2/super.c
+++ b/fs/jffs2/super.c
@@ -112,8 +112,6 @@ static int jffs2_sync_fs(struct super_block *sb, int wait)
 {
 	struct jffs2_sb_info *c = JFFS2_SB_INFO(sb);
 
-	jffs2_write_super(sb);
-
 	mutex_lock(&c->alloc_sem);
 	jffs2_flush_wbuf_pad(c);
 	mutex_unlock(&c->alloc_sem);



More information about the linux-mtd-cvs mailing list