mtd: IFC NAND: utilize oob_required parameter

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Mon May 28 07:59:10 EDT 2012


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=a6976cdfe69756436ed8c22b7a03e47a7efe36fb
Commit:     a6976cdfe69756436ed8c22b7a03e47a7efe36fb
Parent:     d112dc7fa65882279434622a40cbe7677a780c46
Author:     Brian Norris <computersforpeace at gmail.com>
AuthorDate: Wed May 2 10:15:01 2012 -0700
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Sun May 13 23:21:48 2012 -0500

    mtd: IFC NAND: utilize oob_required parameter
    
    Don't read OOB if the caller doesn't require it.
    
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
    Reviewed-by: Scott Wood <scottwood at freescale.com>
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
    Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
 drivers/mtd/nand/fsl_ifc_nand.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
index c085df3..9602c1b 100644
--- a/drivers/mtd/nand/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/fsl_ifc_nand.c
@@ -706,7 +706,8 @@ static int fsl_ifc_read_page(struct mtd_info *mtd, struct nand_chip *chip,
 	struct fsl_ifc_nand_ctrl *nctrl = ifc_nand_ctrl;
 
 	fsl_ifc_read_buf(mtd, buf, mtd->writesize);
-	fsl_ifc_read_buf(mtd, chip->oob_poi, mtd->oobsize);
+	if (oob_required)
+		fsl_ifc_read_buf(mtd, chip->oob_poi, mtd->oobsize);
 
 	if (ctrl->nand_stat & IFC_NAND_EVTER_STAT_ECCER)
 		dev_err(priv->dev, "NAND Flash ECC Uncorrectable Error\n");



More information about the linux-mtd-cvs mailing list