mtd: nand: gpmi: need to use {read,write}_oob_raw

[Linux-MTD Mailing List]

Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=271b874ba1512a1b3bd24edbd4e4116c3b5c15ae
Commit:     271b874ba1512a1b3bd24edbd4e4116c3b5c15ae
Parent:     b9bc815c2c01e8cbc6fe894e3b4ff6bb4313ebcb
Author:     Brian Norris <computersforpeace at gmail.com>
AuthorDate: Fri May 11 13:30:35 2012 -0700
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Fri Jul 6 18:17:02 2012 +0100

    mtd: nand: gpmi: need to use {read,write}_oob_raw
    
    This patch is simply an added warning in the comments. Ideally, this patch
    need not be merged, but rather, a developer will write a proper solution
    that can use the ecc.read_oob_raw and ecc.write_oob_raw interfaces.
    
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
    Cc: Huang Shijie <b32955 at freescale.com>
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
    Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
 drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index a6cad5c..6574c6f 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -1064,6 +1064,9 @@ exit_auxiliary:
  * ECC-based or raw view of the page is implicit in which function it calls
  * (there is a similar pair of ECC-based/raw functions for writing).
  *
+ * FIXME: The following paragraph is incorrect, now that there exist
+ * ecc.read_oob_raw and ecc.write_oob_raw functions.
+ *
  * Since MTD assumes the OOB is not covered by ECC, there is no pair of
  * ECC-based/raw functions for reading or or writing the OOB. The fact that the
  * caller wants an ECC-based or raw view of the page is not propagated down to