mtd: lpddr: drop unnecessary zeroing

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Mon Jan 9 13:59:09 EST 2012


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=cdfe5ed0f271f1d5693fbd68809cc7e0e6c3af66
Commit:     cdfe5ed0f271f1d5693fbd68809cc7e0e6c3af66
Parent:     4a42243886b87cd28a39b192161767c2af851a55
Author:     Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
AuthorDate: Tue Dec 27 17:59:04 2011 +0200
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Mon Jan 9 18:24:48 2012 +0000

    mtd: lpddr: drop unnecessary zeroing
    
    We allocate the "mtd" structure using kzalloc which means we do not have
    to initialize unused MTD function pointers to NULL, since it is safe to
    assume in Linux that NULL contains all zeroes.
    
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
    Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
 drivers/mtd/lpddr/lpddr_cmds.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/drivers/mtd/lpddr/lpddr_cmds.c b/drivers/mtd/lpddr/lpddr_cmds.c
index 1dca31d..536bbce 100644
--- a/drivers/mtd/lpddr/lpddr_cmds.c
+++ b/drivers/mtd/lpddr/lpddr_cmds.c
@@ -70,19 +70,12 @@ struct mtd_info *lpddr_cmdset(struct map_info *map)
 	mtd->erase = lpddr_erase;
 	mtd->write = lpddr_write_buffers;
 	mtd->writev = lpddr_writev;
-	mtd->read_oob = NULL;
-	mtd->write_oob = NULL;
-	mtd->sync = NULL;
 	mtd->lock = lpddr_lock;
 	mtd->unlock = lpddr_unlock;
-	mtd->suspend = NULL;
-	mtd->resume = NULL;
 	if (map_is_linear(map)) {
 		mtd->point = lpddr_point;
 		mtd->unpoint = lpddr_unpoint;
 	}
-	mtd->block_isbad = NULL;
-	mtd->block_markbad = NULL;
 	mtd->size = 1 << lpddr->qinfo->DevSizeShift;
 	mtd->erasesize = 1 << lpddr->qinfo->UniformBlockSizeShift;
 	mtd->writesize = 1 << lpddr->qinfo->BufSizeShift;



More information about the linux-mtd-cvs mailing list