mtd: remove MEMSETOOBSEL macro definition

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Mon Nov 7 11:59:30 EST 2011


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=93fad71c206ca4672360edaf918727b2b64f8ad1
Commit:     93fad71c206ca4672360edaf918727b2b64f8ad1
Parent:     48ee688df09fa3ddf86b5b53508316d18d6fcedd
Author:     Brian Norris <computersforpeace at gmail.com>
AuthorDate: Tue Aug 23 17:17:34 2011 -0700
Committer:  Artem Bityutskiy <artem.bityutskiy at intel.com>
CommitDate: Sun Sep 11 15:02:18 2011 +0300

    mtd: remove MEMSETOOBSEL macro definition
    
    MEMSETOOBSEL is completely unused and useless. Remove the definition.
    
    Note: it's probably best not to use this ioctl number in the future for
    MTD, since that may cause conflicts between old kernels and new user
    software (or new kernels and old user software).
    
    Artem: leave a comment about MEMSETOOBSEL.
    
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy at intel.com>
---
 include/mtd/mtd-abi.h |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/include/mtd/mtd-abi.h b/include/mtd/mtd-abi.h
index 2f7d45b..3bdda5c 100644
--- a/include/mtd/mtd-abi.h
+++ b/include/mtd/mtd-abi.h
@@ -104,6 +104,12 @@ struct otp_info {
 	__u32 locked;
 };
 
+/*
+ * Note, the following ioctl existed in the past and was removed:
+ * #define MEMSETOOBSEL           _IOW('M', 9, struct nand_oobinfo)
+ * Try to avoid adding a new ioctl with the same ioctl number.
+ */
+
 #define MEMGETINFO		_IOR('M', 1, struct mtd_info_user)
 #define MEMERASE		_IOW('M', 2, struct erase_info_user)
 #define MEMWRITEOOB		_IOWR('M', 3, struct mtd_oob_buf)
@@ -112,7 +118,6 @@ struct otp_info {
 #define MEMUNLOCK		_IOW('M', 6, struct erase_info_user)
 #define MEMGETREGIONCOUNT	_IOR('M', 7, int)
 #define MEMGETREGIONINFO	_IOWR('M', 8, struct region_info_user)
-#define MEMSETOOBSEL		_IOW('M', 9, struct nand_oobinfo)
 #define MEMGETOOBSEL		_IOR('M', 10, struct nand_oobinfo)
 #define MEMGETBADBLOCK		_IOW('M', 11, __kernel_loff_t)
 #define MEMSETBADBLOCK		_IOW('M', 12, __kernel_loff_t)



More information about the linux-mtd-cvs mailing list