jffs2: update ctime when changing the file's permission by setfacl

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Sun Jun 6 05:59:01 EDT 2010


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=cc4f11345d6b4e9d1fe24eb79dc7ab584e15e2f3
Commit:     cc4f11345d6b4e9d1fe24eb79dc7ab584e15e2f3
Parent:     00b275dbfc2ae3e3312a910736dd9a6bd5110c2b
Author:     Jan Kara <jack at suse.cz>
AuthorDate: Fri Jun 4 17:07:55 2010 +0200
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Sun Jun 6 10:33:39 2010 +0100

    jffs2: update ctime when changing the file's permission by setfacl
    
    jffs2 didn't update the ctime of the file when its permission was changed.
    
    Steps to reproduce:
     # touch aaa
     # stat -c %Z aaa
     1275289822
     # setfacl -m  'u::x,g::x,o::x' aaa
     # stat -c %Z aaa
     1275289822                         <- unchanged
    
    But, according to the spec of the ctime, jffs2 must update it.
    
    Port of ext3 patch by Miao Xie <miaox at cn.fujitsu.com>.
    
    Signed-off-by: Jan Kara <jack at suse.cz>
    Signed-off-by: Daid Woodhouse <David.Woodhouse at intel.com>
---
 fs/jffs2/acl.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/fs/jffs2/acl.c b/fs/jffs2/acl.c
index 7cdc319..64d3b4b 100644
--- a/fs/jffs2/acl.c
+++ b/fs/jffs2/acl.c
@@ -234,8 +234,9 @@ static int jffs2_set_acl(struct inode *inode, int type, struct posix_acl *acl)
 			if (inode->i_mode != mode) {
 				struct iattr attr;
 
-				attr.ia_valid = ATTR_MODE;
+				attr.ia_valid = ATTR_MODE | ATTR_CTIME;
 				attr.ia_mode = mode;
+				attr.ia_ctime = CURRENT_TIME_SEC;
 				rc = jffs2_do_setattr(inode, &attr);
 				if (rc < 0)
 					return rc;



More information about the linux-mtd-cvs mailing list