mtd: nand: make PCI device id constant
Linux-MTD Mailing List
linux-mtd at lists.infradead.org
Thu Feb 25 07:59:01 EST 2010
Gitweb: http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=377ace08eaaa3fb0c05b3fb7a86a5a1e9eb04673
Commit: 377ace08eaaa3fb0c05b3fb7a86a5a1e9eb04673
Parent: 6029a3a4625e485e01cf9a024d190c9d4e6b6681
Author: Márton Németh <nm127 at freemail.hu>
AuthorDate: Sat Jan 9 15:10:34 2010 +0100
Committer: David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Thu Feb 25 11:26:26 2010 +0000
mtd: nand: make PCI device id constant
The id_table field of the struct pci_driver is constant in <linux/pci.h>
so it is worth to make cafe_nand_tbl also constant.
The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
struct I1 {
...
const struct I2 *x;
...
};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
struct I1 y = {
.x = E,
};
@c@
identifier r.I2;
identifier s.E;
@@
const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const
struct I2 E[] = ...;
// </smpl>
Signed-off-by: Márton Németh <nm127 at freemail.hu>
Cc: Julia Lawall <julia at diku.dk>
Cc: cocci at diku.dk
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>
Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
drivers/mtd/nand/cafe_nand.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/cafe_nand.c b/drivers/mtd/nand/cafe_nand.c
index c828d9a..67e2b33 100644
--- a/drivers/mtd/nand/cafe_nand.c
+++ b/drivers/mtd/nand/cafe_nand.c
@@ -848,7 +848,7 @@ static void __devexit cafe_nand_remove(struct pci_dev *pdev)
kfree(mtd);
}
-static struct pci_device_id cafe_nand_tbl[] = {
+static const struct pci_device_id cafe_nand_tbl[] = {
{ PCI_VENDOR_ID_MARVELL, PCI_DEVICE_ID_MARVELL_88ALP01_NAND,
PCI_ANY_ID, PCI_ANY_ID },
{ }
More information about the linux-mtd-cvs
mailing list