mtd: pxa3xx_nand: Fix PIO data transfer

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Mon Nov 30 07:59:02 EST 2009


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=98ecc914d0a48dbbcbb5fc866ab5b59a52afbd41
Commit:     98ecc914d0a48dbbcbb5fc866ab5b59a52afbd41
Parent:     6b0d9a84124937f048bcb8b21313152b23063978
Author:     David Hunter <hunterd42 at gmail.com>
AuthorDate: Mon Nov 23 21:02:35 2009 -0800
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Mon Nov 30 11:42:04 2009 +0000

    mtd: pxa3xx_nand: Fix PIO data transfer
    
    The shift operator used here to convert from bytes to 32-bit words is
    backwards.
    
    Signed-off-by: David Hunter <hunterd42 at gmail.com>
    Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
 drivers/mtd/nand/pxa3xx_nand.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index 6ea520a..75aa871 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -489,7 +489,7 @@ static int handle_data_pio(struct pxa3xx_nand_info *info)
 	switch (info->state) {
 	case STATE_PIO_WRITING:
 		__raw_writesl(info->mmio_base + NDDB, info->data_buff,
-				info->data_size << 2);
+				info->data_size >> 2);
 
 		enable_int(info, NDSR_CS0_BBD | NDSR_CS0_CMDD);
 
@@ -501,7 +501,7 @@ static int handle_data_pio(struct pxa3xx_nand_info *info)
 		break;
 	case STATE_PIO_READING:
 		__raw_readsl(info->mmio_base + NDDB, info->data_buff,
-				info->data_size << 2);
+				info->data_size >> 2);
 		break;
 	default:
 		printk(KERN_ERR "%s: invalid state %d\n", __func__,



More information about the linux-mtd-cvs mailing list