[MTD] [OneNAND] Use the u_char instead of char in oobbuf

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Sun Feb 3 02:59:01 EST 2008


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=978cb38a296fceac82a8a757f6387d7ef2a21ac6
Commit:     978cb38a296fceac82a8a757f6387d7ef2a21ac6
Parent:     b2581be291aa8595eadf3d6933d04d0f1d01b46d
Author:     Sheng Yongjie (Sam <samsheng at trident.com.cn>
AuthorDate: Thu Dec 13 11:47:33 2007 +0900
Committer:  Kyungmin Park <kyungmin.park at samsung.com>
CommitDate: Tue Jan 29 17:13:24 2008 +0900

    [MTD] [OneNAND] Use the u_char instead of char in oobbuf
    
    In function onenand_verify_oob, local variable oobbuf shall be unsigned char.
    
    In the case of a value is >= 0x80, it's unequal in comparing the value in an unsigned char and signed char.
    
    Signed-off-by: Sheng Yongjie (Sam) <samsheng at trident.com.cn>
    Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
---
 drivers/mtd/onenand/onenand_base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index 44c327a..ad052c8 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -1217,7 +1217,7 @@ int onenand_bbt_read_oob(struct mtd_info *mtd, loff_t from,
 static int onenand_verify_oob(struct mtd_info *mtd, const u_char *buf, loff_t to)
 {
 	struct onenand_chip *this = mtd->priv;
-	char oobbuf[64];
+	u_char oobbuf[64];
 	int status, i;
 
 	this->command(mtd, ONENAND_CMD_READOOB, to, mtd->oobsize);



More information about the linux-mtd-cvs mailing list