[RSLIB] BUG() when passing illegal parameters to decode_rs8() or decode_rs16()

[Linux-MTD Mailing List]

Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=1dd7fdb163645f453f5ae55686511b6fcc2314cd
Commit:     1dd7fdb163645f453f5ae55686511b6fcc2314cd
Parent:     c32b8dcc45c823cf30dcdf0fc37ee2f6b78f38cb
Author:     Jörn Engel <joern at logfs.org>
AuthorDate: Sat Oct 20 23:14:42 2007 +0200
Committer:  David Woodhouse <dwmw2 at infradead.org>
CommitDate: Sat Oct 20 22:29:09 2007 +0100

    [RSLIB] BUG() when passing illegal parameters to decode_rs8() or decode_rs16()
    
    Returning -ERANGE should never happen.
    
    Signed-off-by: Jörn Engel <joern at logfs.org>
    Signed-off-by: David Woodhouse <dwmw2 at infradead.org>
---
 lib/reed_solomon/decode_rs.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/lib/reed_solomon/decode_rs.c b/lib/reed_solomon/decode_rs.c
index a58df56..65bc718 100644
--- a/lib/reed_solomon/decode_rs.c
+++ b/lib/reed_solomon/decode_rs.c
@@ -39,8 +39,7 @@
 
 	/* Check length parameter for validity */
 	pad = nn - nroots - len;
-	if (pad < 0 || pad >= nn)
-		return -ERANGE;
+	BUG_ON(pad < 0 || pad >= nn);
 
 	/* Does the caller provide the syndrome ? */
 	if (s != NULL)