[JFFS2] Fix return value check for mtd->point() in check_node_data()

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Wed Nov 28 06:59:01 EST 2007


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=c2056e1e1ddcca8d43e89543e1795e4457f5d1e9
Commit:     c2056e1e1ddcca8d43e89543e1795e4457f5d1e9
Parent:     6c24e4161e80a5c03e9d969b5db73d8553846037
Author:     Alexey Korolev <akorolev at infradead.org>
AuthorDate: Tue Nov 27 11:25:10 2007 +0000
Committer:  David Woodhouse <dwmw2 at infradead.org>
CommitDate: Wed Nov 28 11:54:55 2007 +0000

    [JFFS2] Fix return value check for mtd->point() in check_node_data()
    
    If we ask it to map 'len' bytes of the device, don't compare against
    some other number and whine that it's different. That's a little silly.
    
    Signed-off-by: Alexey Korolev <akorolev at infradead.org>
    Signed-off-by: David Woodhouse <dwmw2 at infradead.org>
---
 fs/jffs2/readinode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/jffs2/readinode.c b/fs/jffs2/readinode.c
index da22da9..fb89ab5 100644
--- a/fs/jffs2/readinode.c
+++ b/fs/jffs2/readinode.c
@@ -64,7 +64,7 @@ static int check_node_data(struct jffs2_sb_info *c, struct jffs2_tmp_dnode_info
 	 * adding and jffs2_flash_read_end() interface. */
 	if (c->mtd->point) {
 		err = c->mtd->point(c->mtd, ofs, len, &retlen, &buffer);
-		if (!err && retlen < tn->csize) {
+		if (!err && retlen < len) {
 			JFFS2_WARNING("MTD point returned len too short: %zu instead of %u.\n", retlen, tn->csize);
 			c->mtd->unpoint(c->mtd, buffer, ofs, retlen);
 		} else if (err)



More information about the linux-mtd-cvs mailing list