[JFFS2] Improve diagnostic output for 'node added in wrong place' check

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Thu Jun 28 14:59:01 EDT 2007


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=66bfaeaa90432a585d7e9e70605ee4df3ede9890
Commit:     66bfaeaa90432a585d7e9e70605ee4df3ede9890
Parent:     d364fb18cd991734eb54aa8840e70030b0c9f699
Author:     David Woodhouse <dwmw2 at infradead.org>
AuthorDate: Thu Jun 28 19:03:11 2007 +0100
Committer:  David Woodhouse <dwmw2 at infradead.org>
CommitDate: Thu Jun 28 19:03:11 2007 +0100

    [JFFS2] Improve diagnostic output for 'node added in wrong place' check
    
    Jocke has seen this fail. We want to know why.
    
    Signed-off-by: David Woodhouse <dwmw2 at infradead.org>
---
 fs/jffs2/nodemgmt.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/fs/jffs2/nodemgmt.c b/fs/jffs2/nodemgmt.c
index dbc908a..9c3a3bb 100644
--- a/fs/jffs2/nodemgmt.c
+++ b/fs/jffs2/nodemgmt.c
@@ -423,7 +423,12 @@ struct jffs2_raw_node_ref *jffs2_add_physical_node_ref(struct jffs2_sb_info *c,
 	   even after refiling c->nextblock */
 	if ((c->nextblock || ((ofs & 3) != REF_OBSOLETE))
 	    && (jeb != c->nextblock || (ofs & ~3) != jeb->offset + (c->sector_size - jeb->free_size))) {
-		printk(KERN_WARNING "argh. node added in wrong place\n");
+		printk(KERN_WARNING "argh. node added in wrong place at 0x%08x(%d)\n", ofs & ~3, ofs & 3);
+		if (c->nextblock)
+			printk(KERN_WARNING "nextblock 0x%08x", c->nextblock->offset);
+		else
+			printk(KERN_WARNING "No nextblock");
+		printk(", expected at %08x\n", jeb->offset + (c->sector_size - jeb->free_size));
 		return ERR_PTR(-EINVAL);
 	}
 #endif



More information about the linux-mtd-cvs mailing list