[MTD] Remove embedded return in RFD FTL.
Linux-MTD Mailing List
linux-mtd at lists.infradead.org
Mon Jul 23 07:59:01 EDT 2007
Gitweb: http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=030f9e13bec9aaae1def86c23963a1a825ccdab5
Commit: 030f9e13bec9aaae1def86c23963a1a825ccdab5
Parent: 1050643431c74d29ac972141cb24df1d9aca65cd
Author: akpm at linux-foundation.org <akpm at linux-foundation.org>
AuthorDate: Fri Jul 20 11:56:19 2007 -0700
Committer: David Woodhouse <dwmw2 at infradead.org>
CommitDate: Mon Jul 23 12:06:52 2007 +0100
[MTD] Remove embedded return in RFD FTL.
embedded returns are evil.
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
Signed-off-by: David Woodhouse <dwmw2 at infradead.org>
---
drivers/mtd/rfd_ftl.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/rfd_ftl.c b/drivers/mtd/rfd_ftl.c
index 006c03a..823fba4 100644
--- a/drivers/mtd/rfd_ftl.c
+++ b/drivers/mtd/rfd_ftl.c
@@ -779,10 +779,8 @@ static void rfd_ftl_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)
else {
if (!mtd->erasesize) {
printk(KERN_WARNING PREFIX "please provide block_size");
- kfree(part);
- return;
- }
- else
+ goto out;
+ } else
part->block_size = mtd->erasesize;
}
@@ -804,7 +802,7 @@ static void rfd_ftl_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)
if (!add_mtd_blktrans_dev((void*)part))
return;
}
-
+out:
kfree(part);
}
More information about the linux-mtd-cvs
mailing list