Simplify test for RAM devices

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Wed May 3 13:56:31 EDT 2006


commit 7f7c08dfdf5bc0a7c906285d9d97b932f83e8979
tree aaf40f4ef508cee41586e788d7d3f9e7075c364d
parent 94171db1d2f23c22b6050d210b72db3bb2f0b81e
author Jörn Engel <joern at wohnheim.fh-wedel.de> Thu, 13 Apr 2006 18:53:14 +0200
committer David Woodhouse <dwmw2 at infradead.org> Mon, 17 Apr 2006 15:48:16 +0100

Simplify test for RAM devices

mtdblock is the only user of aggregate capabilities in mtd.  This is clearly
bogus and should be changed.  In particular, it tries to determine whether
the device in question is a piece of RAM.  For every single driver that fits
the current criteria, an easier test would be to check for the type being
MTD_RAM.

Signed-off-by: Jörn Engel <joern at wohnheim.fh-wedel.de>
Signed-off-by: David Woodhouse <dwmw2 at infradead.org>

 drivers/mtd/mtdblock.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mtd/mtdblock.c b/drivers/mtd/mtdblock.c
index 2cef280..8e50170 100644
--- a/drivers/mtd/mtdblock.c
+++ b/drivers/mtd/mtdblock.c
@@ -288,8 +288,7 @@ static int mtdblock_open(struct mtd_blkt
 
 	mutex_init(&mtdblk->cache_mutex);
 	mtdblk->cache_state = STATE_EMPTY;
-	if ((mtdblk->mtd->flags & MTD_CAP_RAM) != MTD_CAP_RAM &&
-	    mtdblk->mtd->erasesize) {
+	if (mtdblk->mtd->type != MTD_RAM && mtdblk->mtd->erasesize) {
 		mtdblk->cache_size = mtdblk->mtd->erasesize;
 		mtdblk->cache_data = NULL;
 	}




More information about the linux-mtd-cvs mailing list