mtd/drivers/mtd/devices doc2000.c, 1.64, 1.65 doc2001.c, 1.46,
1.47 doc2001plus.c, 1.11, 1.12 docprobe.c, 1.43, 1.44
David Woodhouse
dwmw2 at infradead.org
Wed Jan 5 07:40:40 EST 2005
Update of /home/cvs/mtd/drivers/mtd/devices
In directory phoenix.infradead.org:/tmp/cvs-serv31865/drivers/mtd/devices
Modified Files:
doc2000.c doc2001.c doc2001plus.c docprobe.c
Log Message:
[PATCH] diskonchip missing iomem annotations
some trivial iomem annotations were still missing; since 2.6.10
and mtd snapshot are identical in that area, same patch goes to Linus and
dwmw2.
Signed-off-by: Al Viro <viro at parcelfarce.linux.theplanet.co.uk>
Index: doc2000.c
===================================================================
RCS file: /home/cvs/mtd/drivers/mtd/devices/doc2000.c,v
retrieving revision 1.64
retrieving revision 1.65
diff -u -r1.64 -r1.65
--- doc2000.c 16 Nov 2004 18:29:01 -0000 1.64
+++ doc2000.c 5 Jan 2005 12:40:36 -0000 1.65
@@ -541,7 +541,7 @@
printk(KERN_NOTICE
"Ignoring DiskOnChip 2000 at 0x%lX - already configured\n",
this->physadr);
- iounmap((void *) this->virtadr);
+ iounmap(this->virtadr);
kfree(mtd);
return;
}
@@ -573,7 +573,7 @@
default:
printk("Unknown ChipID 0x%02x\n", this->ChipID);
kfree(mtd);
- iounmap((void *) this->virtadr);
+ iounmap(this->virtadr);
return;
}
@@ -612,7 +612,7 @@
if (!this->totlen) {
kfree(mtd);
- iounmap((void *) this->virtadr);
+ iounmap(this->virtadr);
} else {
this->nextdoc = doc2klist;
doc2klist = mtd;
@@ -1293,7 +1293,7 @@
del_mtd_device(mtd);
- iounmap((void *) this->virtadr);
+ iounmap(this->virtadr);
kfree(this->chips);
kfree(mtd);
}
Index: doc2001.c
===================================================================
RCS file: /home/cvs/mtd/drivers/mtd/devices/doc2001.c,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -r1.46 -r1.47
--- doc2001.c 16 Nov 2004 18:29:01 -0000 1.46
+++ doc2001.c 5 Jan 2005 12:40:36 -0000 1.47
@@ -346,7 +346,7 @@
if (DoCMil_is_alias(this, old)) {
printk(KERN_NOTICE "Ignoring DiskOnChip Millennium at "
"0x%lX - already configured\n", this->physadr);
- iounmap((void *)this->virtadr);
+ iounmap(this->virtadr);
kfree(mtd);
return;
}
@@ -392,7 +392,7 @@
if (!this->totlen) {
kfree(mtd);
- iounmap((void *)this->virtadr);
+ iounmap(this->virtadr);
} else {
this->nextdoc = docmillist;
docmillist = mtd;
@@ -873,7 +873,7 @@
del_mtd_device(mtd);
- iounmap((void *)this->virtadr);
+ iounmap(this->virtadr);
kfree(this->chips);
kfree(mtd);
}
Index: doc2001plus.c
===================================================================
RCS file: /home/cvs/mtd/drivers/mtd/devices/doc2001plus.c,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- doc2001plus.c 16 Nov 2004 18:29:01 -0000 1.11
+++ doc2001plus.c 5 Jan 2005 12:40:36 -0000 1.12
@@ -470,7 +470,7 @@
printk(KERN_NOTICE "Ignoring DiskOnChip Millennium "
"Plus at 0x%lX - already configured\n",
this->physadr);
- iounmap((void *)this->virtadr);
+ iounmap(this->virtadr);
kfree(mtd);
return;
}
@@ -514,7 +514,7 @@
if (!this->totlen) {
kfree(mtd);
- iounmap((void *)this->virtadr);
+ iounmap(this->virtadr);
} else {
this->nextdoc = docmilpluslist;
docmilpluslist = mtd;
@@ -1139,7 +1139,7 @@
del_mtd_device(mtd);
- iounmap((void *)this->virtadr);
+ iounmap(this->virtadr);
kfree(this->chips);
kfree(mtd);
}
Index: docprobe.c
===================================================================
RCS file: /home/cvs/mtd/drivers/mtd/devices/docprobe.c,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -r1.43 -r1.44
--- docprobe.c 16 Nov 2004 18:29:01 -0000 1.43
+++ docprobe.c 5 Jan 2005 12:40:36 -0000 1.44
@@ -94,9 +94,9 @@
/* doccheck: Probe a given memory window to see if there's a DiskOnChip present */
-static inline int __init doccheck(unsigned long potential, unsigned long physadr)
+static inline int __init doccheck(void __iomem *potential, unsigned long physadr)
{
- unsigned long window=potential;
+ void __iomem *window=potential;
unsigned char tmp, tmpb, tmpc, ChipID;
#ifndef DOC_PASSIVE_PROBE
unsigned char tmp2;
@@ -233,7 +233,7 @@
static void __init DoC_Probe(unsigned long physadr)
{
- unsigned long docptr;
+ void __iomem *docptr;
struct DiskOnChip *this;
struct mtd_info *mtd;
int ChipID;
@@ -243,7 +243,7 @@
char *im_modname = NULL;
void (*initroutine)(struct mtd_info *) = NULL;
- docptr = (unsigned long)ioremap(physadr, DOC_IOREMAP_LEN);
+ docptr = ioremap(physadr, DOC_IOREMAP_LEN);
if (!docptr)
return;
@@ -252,7 +252,7 @@
if (ChipID == DOC_ChipID_Doc2kTSOP) {
/* Remove this at your own peril. The hardware driver works but nothing prevents you from erasing bad blocks */
printk(KERN_NOTICE "Refusing to drive DiskOnChip 2000 TSOP until Bad Block Table is correctly supported by INFTL\n");
- iounmap((void *)docptr);
+ iounmap(docptr);
return;
}
docfound = 1;
@@ -260,7 +260,7 @@
if (!mtd) {
printk(KERN_WARNING "Cannot allocate memory for data structures. Dropping.\n");
- iounmap((void *)docptr);
+ iounmap(docptr);
return;
}
@@ -270,7 +270,7 @@
memset((char *)this, 0, sizeof(struct DiskOnChip));
mtd->priv = this;
- this->virtadr = (void __iomem *)docptr;
+ this->virtadr = docptr;
this->physadr = physadr;
this->ChipID = ChipID;
sprintf(namebuf, "with ChipID %2.2X", ChipID);
@@ -318,7 +318,7 @@
printk(KERN_NOTICE "Cannot find driver for DiskOnChip %s at 0x%lX\n", name, physadr);
kfree(mtd);
}
- iounmap((void *)docptr);
+ iounmap(docptr);
}
More information about the linux-mtd-cvs
mailing list