mtd/drivers/mtd/nand diskonchip.c,1.53,1.54

dbrown at infradead.org dbrown at infradead.org
Thu Apr 7 10:22:58 EDT 2005


Update of /home/cvs/mtd/drivers/mtd/nand
In directory phoenix.infradead.org:/tmp/cvs-serv21422

Modified Files:
	diskonchip.c 
Log Message:
Add helpful comment about oobfree so I can't claim two years from now that I don't remember what I was thinking.


Index: diskonchip.c
===================================================================
RCS file: /home/cvs/mtd/drivers/mtd/nand/diskonchip.c,v
retrieving revision 1.53
retrieving revision 1.54
diff -u -r1.53 -r1.54
--- diskonchip.c	7 Apr 2005 13:39:13 -0000	1.53
+++ diskonchip.c	7 Apr 2005 14:22:55 -0000	1.54
@@ -1049,6 +1049,16 @@
 		
 //u_char mydatabuf[528];
 
+/* The strange out-of-order .oobfree list below is a (possibly unneeded)
+ * attempt to retain compatibility.  It used to read:
+ * 	.oobfree = { {8, 8} }
+ * Since that leaves two bytes unusable, it was changed.  But the following
+ * scheme might affect existing jffs2 installs by moving the cleanmarker:
+ * 	.oobfree = { {6, 10} }
+ * jffs2 seems to handle the above gracefully, but the current scheme seems
+ * safer.  The only problem with it is that any code that parses oobfree must
+ * be able to handle out-of-order segments.
+ */
 static struct nand_oobinfo doc200x_oobinfo = {
         .useecc = MTD_NANDECC_AUTOPLACE,
         .eccbytes = 6,





More information about the linux-mtd-cvs mailing list