mtd/fs/jffs3 scan.c,3.3,3.4

Artem Bityuckiy dedekind at infradead.org
Tue Dec 14 11:14:35 EST 2004


Update of /home/cvs/mtd/fs/jffs3
In directory phoenix.infradead.org:/tmp/cvs-serv30069

Modified Files:
	scan.c 
Log Message:
Remove additional printks. "ptintk is not the place for documentation,
I'd rather come up with a way of determining which bad CRCs are safe,
 node which ends in an unwritten page, etc." (C) dwmw2.


Index: scan.c
===================================================================
RCS file: /home/cvs/mtd/fs/jffs3/scan.c,v
retrieving revision 3.3
retrieving revision 3.4
diff -u -r3.3 -r3.4
--- scan.c	13 Dec 2004 19:02:43 -0000	3.3
+++ scan.c	14 Dec 2004 16:14:32 -0000	3.4
@@ -38,7 +38,6 @@
 #define DBG_NOISY(noise, args...) do { \
 	if (*(noise)) { \
 		NOTICE_MSG(args); \
-		NOTICE_MSG("This may happen if JFFS3 was not cleanly unmounted\n");	\
 		(*(noise))--; \
 		if (!(*(noise))) \
 			NOTICE_MSG("Further such events for this erase block will not be printed\n"); \
@@ -560,7 +559,6 @@
 			if (je32_to_cpu(node->totlen) != c->cleanmarker_size) {
 				NOTICE_MSG("CLEANMARKER node found at %#08x has totlen %#08x != normal %#08x\n",
 				       ofs, je32_to_cpu(node->totlen), c->cleanmarker_size);
-				NOTICE_MSG("This may happen if JFFS3 was not cleanly unmounted\n");
 				DIRTY_SPACE(PAD(sizeof(struct jffs3_unknown_node)));
 				ofs += PAD(sizeof(struct jffs3_unknown_node));
 			} else if (jeb->first_node) {
@@ -713,7 +711,6 @@
 		if (crc != je32_to_cpu(ri->node_crc)) {
 			NOTICE_MSG("CRC failed on node at %#08x: Read %#08x, calculated %#08x\n",
 					ofs, je32_to_cpu(ri->node_crc), crc);
-			NOTICE_MSG("This may happen if JFFS3 was not cleanly unmounted\n");
 			/* We believe totlen because the CRC on the node _header_ was OK, just the node itself failed. */
 			DIRTY_SPACE(PAD(je32_to_cpu(ri->totlen)));
 			jffs3_free_raw_node_ref(raw);
@@ -767,7 +764,6 @@
 	if (crc != je32_to_cpu(rd->node_crc)) {
 		NOTICE_MSG("Node CRC failed on node at %#08x: Read %#08x, calculated %#08x\n",
 			       ofs, je32_to_cpu(rd->node_crc), crc);
-		NOTICE_MSG("This may happen if JFFS3 was not cleanly unmounted\n");
 		/* We believe totlen because the CRC on the node _header_ was OK, just the node itself failed. */
 		DIRTY_SPACE(PAD(je32_to_cpu(rd->totlen)));
 		return 0;
@@ -786,7 +782,6 @@
 	if (crc != je32_to_cpu(rd->name_crc)) {
 		NOTICE_MSG("jffs3_scan_dirent_node(): Name CRC failed on node at %#08x: Read %#08x, "
 				"calculated %#08x\n", ofs, je32_to_cpu(rd->name_crc), crc);	
-		NOTICE_MSG("This may happen if JFFS3 was not cleanly unmounted\n");
 		DBG_SCAN(1, "Name for which CRC failed is (now) '%s', ino #%d\n",
 					fd->name, je32_to_cpu(rd->ino));
 		jffs3_free_full_dirent(fd);





More information about the linux-mtd-cvs mailing list