mtd/drivers/mtd/maps octagon-5066.c,1.19,1.20
David Woodhouse
dwmw2 at infradead.org
Tue Jan 7 12:21:57 EST 2003
Update of /home/cvs/mtd/drivers/mtd/maps
In directory phoenix.infradead.org:/tmp/cvs-serv7186
Modified Files:
octagon-5066.c
Log Message:
From: william stinson <wstinson at wanadoo.fr>
Hi Jason,
this patch for drivers/mtd/maps/octagon-5066.c MTD map driver for Octagon 5066 Single Board Computer
removes one call to check_region using request_region instead.
Index: octagon-5066.c
===================================================================
RCS file: /home/cvs/mtd/drivers/mtd/maps/octagon-5066.c,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- octagon-5066.c 2 Oct 2001 15:05:14 -0000 1.19
+++ octagon-5066.c 7 Jan 2003 17:21:55 -0000 1.20
@@ -223,33 +223,32 @@
}
}
iounmap((void *)iomapadr);
- release_region(PAGE_IO,1);
+ release_region(PAGE_IO, 1);
}
int __init init_oct5066(void)
{
int i;
-
+ int ret = 0;
+
// Do an autoprobe sequence
- if (check_region(PAGE_IO,1) != 0)
- {
- printk("5066: Page Register in Use\n");
- return -EAGAIN;
- }
+ if (!request_region(PAGE_IO,1,"Octagon SSD")) {
+ printk(KERN_NOTICE "5066: Page Register in Use\n");
+ return -EAGAIN;
+ }
iomapadr = (unsigned long)ioremap(WINDOW_START, WINDOW_LENGTH);
if (!iomapadr) {
- printk("Failed to ioremap memory region\n");
- return -EIO;
+ printk(KERN_NOTICE "Failed to ioremap memory region\n");
+ ret = -EIO;
+ goto out_rel;
}
- if (OctProbe() != 0)
- {
- printk("5066: Octagon Probe Failed, is this an Octagon 5066 SBC?\n");
- iounmap((void *)iomapadr);
- return -EAGAIN;
- }
-
- request_region(PAGE_IO,1,"Octagon SSD");
-
+ if (OctProbe() != 0) {
+ printk(KERN_NOTICE "5066: Octagon Probe Failed, is this an Octagon 5066 SBC?\n");
+ iounmap((void *)iomapadr);
+ ret = -EAGAIN;
+ goto out_unmap;
+ }
+
// Print out our little header..
printk("Octagon 5066 SSD IO:0x%x MEM:0x%x-0x%x\n",PAGE_IO,WINDOW_START,
WINDOW_START+WINDOW_LENGTH);
@@ -272,8 +271,14 @@
cleanup_oct5066();
return -ENXIO;
}
-
+
return 0;
+
+ out_unmap:
+ iounmap((void *)iomapadr);
+ out_rel:
+ release_region(PAGE_IO, 1);
+ return ret;
}
module_init(init_oct5066);
More information about the linux-mtd-cvs
mailing list