MTD CVS update: 'mtd/drivers/mtd/chips cfi_cmdset_0001.c cfi_cmdset_0002.c cfi_probe.c'

nico at infradead.org nico at infradead.org
Sat Jun 2 21:32:57 EDT 2001


Update of /home/cvs/mtd/drivers/mtd/chips
In directory infradead.org:/tmp/cvs-serv415/drivers/mtd/chips

Modified Files:
	cfi_cmdset_0001.c cfi_cmdset_0002.c cfi_probe.c 
Log Message:
Tentatively cleaned up a bit further common CFI macro usage for code reduction
with fixed bus geometry.  Tried to push reference to the cfi struct far down as
possible with the nice effect of reducing the number of arguments to many
function calls.  It also removed warnings about unused variables in
cfi_cmdset_0001.s when single interleave is configured.

STILL... cfi_probe.c looks like a total mess!  There is certainly a way to
reduce the code splat and increase readability with clever use of some macros.
Yet there are some defined in cfi.h that could be put to use already.

Open questions:
- Is the spot in cfi_probe.c I marked with a "FIXME" actually buggy?
- Are those calls to cfi_send_gen_cmd() with a static device type parameter
  like CFI_DEVICETYPE_X8 actually meant?  Could they use cfi->device_type
  instead?  If so we could get rid of it since a *cfi is already passed to it.
- Why am I writing all this here?  Strange idea, hey?






More information about the linux-mtd-cvs mailing list